Add a usedEncoding method to HTML5Parser, fix #121 #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/445 This is an external review system which you may optionally use for the code review of your pull request. |
|
Do we actually want this to be a method and not just an attribute? |
|
On the parser it could be a property rather than a method. I can update the PR if you prefer that, I don’t have a strong opinion. |
|
One changed line was missing in the last commit, which I just updated. Force-pushing an amended commit has apparently upset Critic… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be easy enough to add.
I don’t really like the
usedEncodingname, but I don’t have a better idea. Feel free to suggest something else.